[AC21.4] Avoid a crash in Cygwin when clicking File -> Print under Win32

Vin Shelton acs at xemacs.org
Sat Dec 9 13:38:49 EST 2006


APPROVE COMMIT 21.4

Made the obvious fix.  Thanks for the patch, Aidan.

I will commit a fix for 21.5.

  - Vin



On 12/9/06, Aidan Kehoe <kehoea at parhasard.net> wrote:
>
>  Ar an t-ochtú lá de mí na Nollaig, scríobh Vin Shelton:
>
>  > QUERY
>  >
>  > >
>  > > [...] It's Vin's call as to whether it goes into 21.4, but I see no
>  > > reason for it not to. [...]
>  > >
>  > >  static void
>  > >  init_native_sound (struct device *d)
>  > >  {
>  > > -  if (DEVICE_TTY_P (d) || DEVICE_STREAM_P (d) || DEVICE_MSWINDOWS_P(d))
>  > > +  if (!(DEVICE_X_P(d) || DEVICE_GTK_P(dev)))
>  >
>  > I don't know much about this part of the code (or anything about gtk),
>  > but what is dev?  If I got the regexp syntax correct, this is the only
>  > occurance in the source file.
>
> Hah, that is indeed a reason for it not to go in. (dev) should have been
> (d), and as it is that code won't compile with GTK.
>
> --
> Santa Maradona, priez pour moi!
>


-- 
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506



More information about the XEmacs-Patches mailing list