Repair to access checking in Win32

Vin Shelton acs at xemacs.org
Sun Nov 19 13:47:20 EST 2006


Benson,

Thank you very much for this patch:

On 11/18/06, Benson Margulies <bim2006 at basistech.com> wrote:
> Index: fileio.c
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/fileio.c,v
> retrieving revision 1.66.2.7
> diff -u -r1.66.2.7 fileio.c
> --- fileio.c    2005/01/31 02:55:14     1.66.2.7
> +++ fileio.c    2006/11/18 21:12:37

I applied the patch you submitted to xemacs-beta; that seems to do the
job for WIN32_NATIVE!  This is a big improvement; I always wondered
why I would occasionally get the one-off "File not found and directory
write-protected message".  Thanks for addressing this!

Here are my comments:

In general, many of us find the 'patcher' package a very easy way to
submit XEmacs packages.  In particular, patcher takes care of:

1. Please include a ChangeLog entry for your submissions.
2. Attaching your diff keeps various mailers from munging the message
contents and greatly increases the chance that the patch will arrive
intact.

In specific - not being the kind to look a gift horse in the mouth -
it would be very useful to extend the patch so that it worked under
Cygwin, too.  Do you think you could manage that?

Thank you,
  Vin Shelton

-- 
The Journey by Mary Oliver
http://www.poemhunter.com/p/m/poem.asp?poet=6771&poem=30506



More information about the XEmacs-Patches mailing list