[AC21.5] Re: strlwr

[Adrian Aichner]

APPROVE COMMIT 21.5

"Robert Pluim" <rpluim at gmail.com> writes:

> On 11/22/06, Stephen J. Turnbull <turnbull at sk.tsukuba.ac.jp> wrote:
>
>     Ilya N. Golubev writes:
>    
>     > Your 2006-11-01 change of `sysdep.c' in main cvs trunk makes `strlwr',
>     > `wcslen' require iso c99, and breaks compilation with pre- c99
>     > compilers.  Please fix.
>    
>     Adrian is currently not able to devote much attention to XEmacs; can
>     you be more specific so that somebody else can do the work?
>
> From inspection of sysdep.c, I assume Ilya means something like this:
>
> 2006-11-23  Robert Pluim  < rpluim at gmail.com>
>
>     * sysdep.c (strlwr): Don't intermix declarations and code.
>     (wcslen): ditto

Thanks for the patch, Robert!

I have just committed it with some minor whitespace fixes to the
ChangeLog entry.

Best regards!

Adrian

>
> Index: sysdep.c
> ===================================================================
> RCS file: /pack/xemacscvs/XEmacs/xemacs/src/sysdep.c,v
> retrieving revision 1.84
> diff -u -r1.84 sysdep.c
> --- sysdep.c    2006/11/01 20:25:49    1.84
> +++ sysdep.c    2006/11/23 08:32:08
> @@ -3491,8 +3491,8 @@
>  size_t
>  wcslen (const wchar_t *s)
>  {
> -  if (s == NULL) return NULL;
>    const wchar_t *p = s;
> +  if (s == NULL) return NULL;
>  
>    while (*p++)
>      ;
> @@ -3509,8 +3509,8 @@
>  char *
>  strlwr (char *s)
>  {
> -  if (s == NULL) return NULL;
>    REGISTER char *c;
> +  if (s == NULL) return NULL;
>  
>    for (c = s; *c; c++)
>      {
>
> _______________________________________________
> XEmacs-Beta mailing list
> XEmacs-Beta at xemacs.org
> http://calypso.tux.org/cgi-bin/mailman/listinfo/xemacs-beta

-- 
Adrian Aichner
 mailto:adrian at xemacs.org
 http://www.xemacs.org/