[PATCH 21.5] Starting XEmacs 21.5 via cygwin's run command

[Adrian Aichner]

"Vin Shelton" <acs at xemacs.org> writes:

> --- src/frame-msw.c.orig	2007-08-15 09:01:09.769610000 -0400
> +++ src/frame-msw.c	2007-08-18 15:32:48.156250000 -0400
> @@ -304,10 +304,15 @@
>  static void
>  mswindows_init_frame_3 (struct frame *f)
>  {
> -  /* Don't do this earlier or we get a WM_PAINT before the frame is ready */
> -  ShowWindow (FRAME_MSWINDOWS_HANDLE (f), SW_SHOWNORMAL);
> -  SetForegroundWindow (FRAME_MSWINDOWS_HANDLE (f));
> -  DragAcceptFiles (FRAME_MSWINDOWS_HANDLE (f), TRUE);
> +  /* Don't do this earlier or we get a WM_PAINT before the frame is ready.
> +   * The SW_x parameter in the first call that an app makes to ShowWindow is
> +   * ignored, and the parameter specified in the caller's STARTUPINFO is
> +   * substituted instead. That parameter is SW_HIDE if we were started by
> +   * runemacs, so call this twice. #### runemacs is evil */
> +  ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_SHOWNORMAL);

Hi Vin, I would recommend putting in a comment here, mentioning why
this second call is done.  A message-id reference to relevant emails
may be useful too.  We know how much a URL to our mail archives is
worth these days :-)

Adrian

> +  ShowWindow (FRAME_MSWINDOWS_HANDLE(f), SW_SHOWNORMAL);
> +  SetForegroundWindow (FRAME_MSWINDOWS_HANDLE(f));
> +  DragAcceptFiles (FRAME_MSWINDOWS_HANDLE(f), TRUE);
>  }
>
>  static void
>
>
> I will apply this patch in a few days if no one objects.
>
> Discussion welcome.
>
> Regards,
>   Vin

-- 
Adrian Aichner
 mailto:adrian at xemacs.org
 http://www.xemacs.org/