[COMMIT] Keep around gensym correspondence information through entire bytecomp files

Stephen J. Turnbull stephen at xemacs.org
Sat Dec 1 16:31:05 EST 2007


QUERY

Aidan Kehoe writes:

 > I'm about to commit a change to move the iso-8859-[...] coding
 > systems away from ISO 2022

This is a really inappropriate change to commit without review.
Please don't do that.

Specifically, what exactly do you mean by this?  They are profiles of
ISO 2022, it says so right in the standards.  If you mean the
implementations, that's OK in theory but is likely to hose people in
practice (they won't be able to read files that have inadvertantly
used ISO 2022 escapes).

However, they should show up as a subclass of ISO 2022 in
describe-coding-system.

 > 
 > 	* bytecomp.el (byte-compile-output-file-form):
 > 	Bind print-gensym to a cons, to tell the Lisp printer not to clear
 > 	print-gensym-alist on exit from #'print. This is appropriate
 > 	because #'byte-compile-output-file-form may be called multiple
 > 	times for a given output file, and re-using the
 > 	#1=#:... placeholders in that context is inappropriate. 

do you mean "reusing placeholders is APPROPRIATE" here?  I think you
should be a little more explict if not.  Do you mean something like
"continuing to increment the placeholders is appropriate" rather than
"reusing the placeholders is inappropriate"?

A comment at the point of change would be appropriate, here.

Does this change the behavior of byte-compiled libraries?



More information about the XEmacs-Patches mailing list