[Q21.5] Make the X11 font menu work again.

[Stephen J. Turnbull]

QUERY

Aidan Kehoe writes:

 > lisp/ChangeLog addition:
 > 
 > 2007-01-02  Aidan Kehoe  <kehoea at parhasard.net>
 > 
 > 	* cus-face.el (custom-set-face-update-spec):
 > 	Fix some formatting. 
 > 	* faces.el (reset-face):
 > 	reset-face resets other faces to behave like the default face--it
 > 	shouldn't do anything if it's handed the default face. 

I don't understand why you changed the code rather than the docstring.
Ie, it makes sense to reset the default face, which results in it
behaving according to its fallbacks.  `reset-face' is marked as a
dangerous, irreversible function; isn't that enough?

 > 	* font-menu.el:
 > 	* font-menu.el (font-menu-set-font):
 > 	If the font was initialised from X resources (the tag-set
 > 	contains 'x-resource) pretend to Custom that it has
 > 	responsibility for those settings.

I don't understand the logic for this.  If people want a font to be
controlled by Custom, let them set it via Custom, no?  Is this needed
to make the font-menu work?  I guess you can recover the resource
settings by reinitializing the face, but wouldn't it be preferable to
keep the resource-based instantiators and implement reset-to-default
by clearing instantiators with the Custom tag-set?

In general:

Brief testing indicates that the font menu is still very broken under
Xft.  That's expected, right?  I haven't tried a non-Xft build yet.