[Q] respect CODESYS in `insert-file-contents-internal'.
Nix
nix at esperi.org.uk
Sat Jan 27 15:12:59 EST 2007
On 27 Jan 2007, Stephen J. Turnbull spake thusly:
> Nix writes:
>
> > (The underlying problem in 21.4 was that insert_file_contents didn't
> > actually *change* the coding system in use to that specified by the
> > CODESYS, but *did* call the file-name-handlers,
>
> OK. I have doubt that's been fixed in 21.4 yet, but I'm pretty sure I
> can find the appropriate place, and probably your old patch in the
> archives. I assume your recommendation is to apply a similar patch to
> 21.4.
Yes, that would be a good idea. (The patch applies fine, it just needs
some shifting around. The old patch in the archives should apply without
changes.)
> I notice in looking at insert-file-contents-internal in 21.4 that if a
> handler is called, then the "goto handled" jumps past all of the
> unbind_to (speccount, Qnil) calls. That would seem to be a horrible
> error, isn't that so? Am I missing something?
I don't think you are. I'd say inserting an unbind_to() at the jump site
is probably easiest, given that you can't move the unbind_to() sitting
just before handled: down to below it without fubaring the I/O error
handling.
--
`The serial comma, however, is correct and proper, and abandoning it will
surely lead to chaos, anarchy, rioting in the streets, the Terrorists
taking over, and possibly the complete collapse of Human Civilization.'
More information about the XEmacs-Patches
mailing list