[PATCH] ISO weeks for calendar

[Michael Welle]

Hi Mats,

Mats Lidell wrote:
> 
> >>>>> Michael wrote:
> 
> Michael> several moons ago I hacked up calendar mode to display the
> Michael> ISO or business weeks within the calendar.
> 
> ISO weeks is a good thing. I have been wanting them too. Nice that you
> have given it a try.
> 
> Michael> Perhaps some kind soul (who has deeper lisp knowledge than I
> Michael> have) may find this useful and can do a review of this piece
> Michael> of code. 
> 
> I don't know about deep lisp knowledge but I found one or possibly two
> problems when I tried the patch.
> 
> ======================================================================
> * 1 -- The function calendar-iso-from-absolute is not loaded. Added an
>   autoload for that.
OK. Hm, I guess, this and lots of other stuff (which comes to daylight
if some other people use this hack ;-) are depending on how calendar
is customized and how it is used. In my environment this one is not a
problem. But you are right. Better adding the autoload.


[...]
> ======================================================================
> * 2 -- The week numbers are accepted as valid dates causing
>   insert-diary-entry to behave odd. Should be "Not a valid date" just
>   as if doing the same on other bad positions in the buffer I think.
> 
>   This is what I came up with -- Ignore the match if in iso week
>   columns. Please check and improve. (Partial patch: Just the defun
>   calendar-insert-indented included.)
Good catch. 


[...]
> Michael> I hope to see it in the calendar package someday.
> 
> This patch looks promising for the upstream version of calendar. You
> might want to try to get it in there.
I will incorporate your patches, give credit and than try to contact
Glenn Morris.

Thanks for your effort
Michael




-- 
biff4emacsen - A biff-like tool for (X)Emacs
http://www.c0t0d0s0.de/biff4emacsen/biff4emacsen.html