Simplify redisplay-x/separate_textual_runs

Olivier Galibert galibert at pobox.com
Fri Mar 30 05:45:20 EDT 2007


On Fri, Mar 30, 2007 at 01:51:51PM +0900, Stephen J. Turnbull wrote:
> Olivier Galibert writes:
> 
>  > Please review (it's hairy code, another pair of eyes is no luxury) and
>  > apply if happy.  It's probably easier in that specific case to check
>  > the result rather than the diff.
> 
> A careful review later, but first a cosmetic suggestion: reorder the
> functions to go from simpler to more complex, probably
> 
> separate_textual_runs_nomule
> separate_textual_runs_xft_nomule
> separate_textual_runs_xft_mule
> separate_textual_runs_mule

No problem.  I frankly don't care either way :-)


>  > +  for (i = 0; i < len; i++)
>  > +    *text_storage++ = str[i];
> 
> Did the no-Mule, no-Xft case get *too bald* for you so you had to
> introduce some hair?<wink>

Hmmm.  More of a case of not removing enough.  What would you like,
memcpy?  Reuse str? (I'm not sure about the relative lifetimes of
run_storage, text_storage and str...).

  OG.



More information about the XEmacs-Patches mailing list