[Q] #'featurep byte-optimisation

Michael Sperber sperber at informatik.uni-tuebingen.de
Mon Sep 3 05:51:21 EDT 2007


Generally, the change seems fine.  But do we really need to use regexps
for this kind of thing?  It took me about 10 minutes to understand why
the regexp actually works.  Can't we do something like this (untested
and probably at least a bit incorrect):

(defvar features-always-true '(xemacs sxemacs))

...
(defun byte-optimize-featurep (form)
   (if (and (consp (cdr form))
            (eq? 'quote (cadr form))
            (consp (cddr form))
            (memq (caddr form) features-always-true))
     ...))

-- 
Cheers =8-} Mike
Friede, Völkerverständigung und überhaupt blabla



More information about the XEmacs-Patches mailing list