[COMMIT] Correct a bug with previous overlay.el patch

Aidan Kehoe kehoea at parhasard.net
Fri Apr 11 15:23:06 EDT 2008


NOTE: This patch has been committed.

APPROVE COMMIT

xemacs-packages/fsf-compat/ChangeLog addition:

2008-04-11  Aidan Kehoe  <kehoea at parhasard.net>

	* overlay.el (overlay-normalize-begin-end-buffer): 
	Correct a bug where the value for BUFFER wasn't passed back; make
	docstring clearer, make normalisation of the BUFFER argument more
	concise. 


XEmacs Packages source patch:
Diff command:   cvs -q diff -Nu
Files affected: xemacs-packages/fsf-compat/overlay.el
===================================================================
RCS

Index: xemacs-packages/fsf-compat/overlay.el
===================================================================
RCS file: /pack/xemacscvs/XEmacs/packages/xemacs-packages/fsf-compat/overlay.el,v
retrieving revision 1.3
diff -u -u -r1.3 overlay.el
--- xemacs-packages/fsf-compat/overlay.el	2008/04/10 21:30:50	1.3
+++ xemacs-packages/fsf-compat/overlay.el	2008/04/11 19:21:00
@@ -82,21 +82,19 @@
 	   pos))))
 
 (defsubst overlay-normalize-begin-end-buffer (beg end &optional buffer)
-  "BEG and END will be normalized so 1 <= BEG <= END <= \(1+ \(length BUFFER)).
+  "Normalize BEG and END so that 1 <= BEG <= END <= \(1+ \(length BUFFER)).
 
 If BUFFER is nil, the current buffer is assumed.  If BEG is
-greater than END, exchange their value."
+greater than END, exchange their value.
 
-  (if (null buffer)
-      (setq buffer (current-buffer))
-    (check-argument-type 'bufferp buffer))
-
+Returns values BEG END BUFFER.  See `multiple-value-setq' and
+`multiple-value-bind'. "
+  (check-argument-type #'bufferp (setq buffer (or buffer (current-buffer))))
   (setq beg (overlay-normalize-pos beg buffer)
 	end (overlay-normalize-pos end buffer))
-
   (when (> beg end)
     (setq beg (prog1 end (setq end beg))))
-  (values beg end))
+  (values beg end buffer))
 
 (defun make-overlay (beg end &optional buffer front-advance rear-advance)
   "Create a new overlay with range BEG to END in BUFFER.

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?



More information about the XEmacs-Patches mailing list