commit: Return a list copy in #'built-in-face-specifiers, pre-empting modification.

Aidan Kehoe aidan-guest at alioth.debian.org
Sun Dec 21 12:23:48 EST 2008


changeset:   4532:16906fefc8df0d642aec6fd43d78637af0054965
tag:         tip
user:        Aidan Kehoe <kehoea at parhasard.net>
date:        Sun Dec 21 17:23:06 2008 +0000
files:       src/ChangeLog src/faces.c
description:
Return a list copy in #'built-in-face-specifiers, pre-empting modification.

2008-12-21  Aidan Kehoe  <kehoea at parhasard.net>

	* faces.c (Fbuilt_in_face_specifiers):
	Don't simply warn the user not to modify
	Vbuilt_in_face_specifiers, enforce this by returning a copy of the
	list.


diff -r b58af9a9765dec7ac331ed18350012172389688d -r 16906fefc8df0d642aec6fd43d78637af0054965 src/ChangeLog
--- a/src/ChangeLog	Sun Nov 02 03:59:54 2008 +0900
+++ b/src/ChangeLog	Sun Dec 21 17:23:06 2008 +0000
@@ -1,3 +1,10 @@ 2008-11-02  Stephen J. Turnbull  <stephe
+2008-12-21  Aidan Kehoe  <kehoea at parhasard.net>
+
+	* faces.c (Fbuilt_in_face_specifiers): 
+	Don't simply warn the user not to modify
+	Vbuilt_in_face_specifiers, enforce this by returning a copy of the
+	list. 
+
 2008-11-02  Stephen J. Turnbull  <stephen at xemacs.org>
 
 	G++ 4.3 complains a lot about implicit conversions of string
diff -r b58af9a9765dec7ac331ed18350012172389688d -r 16906fefc8df0d642aec6fd43d78637af0054965 src/faces.c
--- a/src/faces.c	Sun Nov 02 03:59:54 2008 +0900
+++ b/src/faces.c	Sun Dec 21 17:23:06 2008 +0000
@@ -703,11 +703,10 @@ Return the name of the given face.
 
 DEFUN ("built-in-face-specifiers", Fbuilt_in_face_specifiers, 0, 0, 0, /*
 Return a list of all built-in face specifier properties.
-Don't modify this list!
 */
        ())
 {
-  return Vbuilt_in_face_specifiers;
+  return Fcopy_list(Vbuilt_in_face_specifiers);
 }
 
 /* These values are retrieved so often that we make a special





More information about the XEmacs-Patches mailing list