commit: Correct the perhaps_init_unseen_key_defaults GTK code; don't override X11 fonts.

Aidan Kehoe kehoea at parhasard.net
Wed Jan 2 16:24:56 EST 2008


 Ar an dara lá de mí Eanair, scríobh Aidan Kehoe: 

 > [...] description:
 > Correct the perhaps_init_unseen_key_defaults GTK code; don't override X11 fonts.
 > 
 > 2008-01-02  Aidan Kehoe  <kehoea at parhasard.net>
 > 
 > 	* emacs.c (main_1):
 > 	Call the new vars_of_console_gtk function.
 > 	* console-gtk.c (vars_of_console_gtk): New.
 > 	* console-gtk.c (gtk_perhaps_init_unseen_key_defaults):
 > 	Correct the initialisation of the hash table, on the model of the
 > 	MSW and TTY builds.
 > 
 > 2008-01-02  Aidan Kehoe  <kehoea at parhasard.net>
 > 
 > 	* gtk-init.el (init-post-gtk-win):
 > 	Trust the X11 code to give us decent default fonts.

In experimentation a couple of months ago with these changes, I could
provoke regular assertion failures, involving the weak hash table stored as
FRAME_GTK_WIDGET_CALLBACK_HASH_TABLE. I didn’t note exactly what provoked
them, thinking I would get back to it soon, solve it, and commit the
changes, and now I can’t reproduce them. Furthermore, while previously
typing any character that would provoke a
gtk_perhaps_init_unseen_key_defaults led to a crash, now it leads to that
character being inserted twice, which is a slight improvement, but not
correct.

Basically, the GTK build is unstable and undertested. Bugfixes and further
investigation welcome.

-- 
¿Dónde estará ahora mi sobrino Yoghurtu Nghé, que tuvo que huir
precipitadamente de la aldea por culpa de la escasez de rinocerontes?



More information about the XEmacs-Patches mailing list